Comments on: 5 Tips for Writing Cleaner PHP Code http://www.ultramegatech.com/blog/2009/06/5-tips-for-writing-cleaner-php-code/ Web development blog from UltraMega Tech. Wed, 10 Mar 2010 19:09:15 -0800 http://wordpress.org/?v=2.9.2 hourly 1 By: Steve http://www.ultramegatech.com/blog/2009/06/5-tips-for-writing-cleaner-php-code/comment-page-1/#comment-1125 Steve Mon, 01 Feb 2010 18:18:43 +0000 http://www.ultramegatech.com/blog/?p=406#comment-1125 Those are some good points. I have just always used constants with a unique prefix for configuration directives without problems. Though storing configuration in a class is a great idea, and safer since it doesn't pollute the global namespace. Maybe I'll write a follow up post about that. Thanks for the comment. Those are some good points. I have just always used constants with a unique prefix for configuration directives without problems. Though storing configuration in a class is a great idea, and safer since it doesn’t pollute the global namespace. Maybe I’ll write a follow up post about that. Thanks for the comment.

]]> By: PHPGangsta http://www.ultramegatech.com/blog/2009/06/5-tips-for-writing-cleaner-php-code/comment-page-1/#comment-1124 PHPGangsta Mon, 01 Feb 2010 01:29:01 +0000 http://www.ultramegatech.com/blog/?p=406#comment-1124 I read number 4 and I'm not sure if this is a really good tip. I perhaps would be a bit more precise and say "class constant" or something like that, because I personally hate global variables and global constants. And I think avoiding global variables and constants is one of the tips to good programmers, too. Also global constants are a problem if you use/integrate another project, and this code also defines a constant named "DB_NAME" as your project does. This could be a problem then. Reusing the code is also difficult if your code relies on global constants. If you want an array or an object as a constant, that is not possible. So the best solution perhaps is a class with attributes that you cannot change (only __get()), then you are much more flexible I think. See for example this nice examples: http://www.benlog.org/2008/1/24/php-be-careful-with-global-constants/ I read number 4 and I’m not sure if this is a really good tip. I perhaps would be a bit more precise and say “class constant” or something like that, because I personally hate global variables and global constants. And I think avoiding global variables and constants is one of the tips to good programmers, too.

Also global constants are a problem if you use/integrate another project, and this code also defines a constant named “DB_NAME” as your project does. This could be a problem then.

Reusing the code is also difficult if your code relies on global constants.

If you want an array or an object as a constant, that is not possible. So the best solution perhaps is a class with attributes that you cannot change (only __get()), then you are much more flexible I think.

See for example this nice examples:
http://www.benlog.org/2008/1/24/php-be-careful-with-global-constants/

]]> By: UltraMega http://www.ultramegatech.com/blog/2009/06/5-tips-for-writing-cleaner-php-code/comment-page-1/#comment-101 UltraMega Sun, 02 Aug 2009 20:43:36 +0000 http://www.ultramegatech.com/blog/?p=406#comment-101 Yeah that was a typo. Fixed it. And yes, most of this should be common sense to anyone with some experience, but you never know... Yeah that was a typo. Fixed it. And yes, most of this should be common sense to anyone with some experience, but you never know…

]]> By: keogh http://www.ultramegatech.com/blog/2009/06/5-tips-for-writing-cleaner-php-code/comment-page-1/#comment-100 keogh Sun, 02 Aug 2009 20:25:35 +0000 http://www.ultramegatech.com/blog/?p=406#comment-100 Good post! only one thing, I think that you misspelled at "[..]Keep everything as sort as possible..." don't you want to mean 'short' instead of 'sort'. Sort doesn't has any meaning to me on that sentence. Eventhough it's a good post, I've been applied all of these tips from long time ago by common sense and experience with PHP programming, this is good for newbies! Nice blog too! Regards Good post! only one thing, I think that you misspelled at “[..]Keep everything as sort as possible…” don’t you want to mean ’short’ instead of ’sort’. Sort doesn’t has any meaning to me on that sentence.

Eventhough it’s a good post, I’ve been applied all of these tips from long time ago by common sense and experience with PHP programming, this is good for newbies!

Nice blog too!

Regards

]]>